-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(component-store): make synchronous updater errors catchable #3490
fix(component-store): make synchronous updater errors catchable #3490
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
return EMPTY; | ||
} | ||
|
||
return throwError(() => error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! So this will error the async updater but not the general state$
👍
36653bc
to
c3b3e00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @markostanimirovic 👍
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3266
What is the new behavior?
All synchronous errors are now catchable. Also, error handling is changed - an error will not be emitted to the
stateSubject$
anymore, it will be thrown instead.Does this PR introduce a breaking change?
As we discussed at the last team meeting, this should not be considered a breaking change.