Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example-app): remove occurrence of deprecated entryComponents #3531

Merged

Conversation

mauromattos00
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The entryComponents property is still being used in the auth.module inside the example app.

Closes #3523

What is the new behavior?

The entryComponents property is now removed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 14, 2022

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c59daa1
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62f880127ea1c0000939d74d
😎 Deploy Preview https://deploy-preview-3531--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts changed the title refactor(example): remove outdated property refactor(example-app): remove occurrence of deprecated entryComponents Aug 14, 2022
@markostanimirovic markostanimirovic merged commit 4da9a67 into ngrx:master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove entryComponents from example app
3 participants