feat(data): add provideEntityData and provideEntityDataWithoutEffects

[santoshyadavdev]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #3529

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[netlify]

✅ Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	6076e41
🔍 Latest deploy log	https://app.netlify.com/sites/ngrx-io/deploys/636589c68ffb720008bd79b4

[markostanimirovic]

Thanks a lot Santosh for reopening this PR!

[markostanimirovic]

I didn't add TSDoc and tests for the new data APIs yesterday, but it would be good to cover at least the main use cases. If you don't have time, we can add tests in a separate PR.

I'd also revert changes from standalone-app. We could improve the data-example-app project in the future and use standalone APIs there.

[santoshyadavdev]

Sounds good I need to work on my slides. Should I disable these tests as of now and update once I am back?

Will update the standalone-app

[markostanimirovic]

Hey @santoshyadavdev,

We don't need to exclude existing @ngrx/data tests. The suggestion above should fix existing tests (imports: [EntityDataModuleWithoutEffects] is currently missing).

[santoshyadavdev]

Hey @santoshyadavdev,

We don't need to exclude existing @ngrx/data tests. The suggestion above should fix existing tests (imports: [EntityDataModuleWithoutEffects] is currently missing).

oops, my bad, really sorry, I am too tired 😂

[markostanimirovic]

oops, my bad, really sorry, I am too tired 😂

Oh 😅 No worries!

[markostanimirovic]

🚀

[brandonroberts]

Changes look good overall. We have an opportunity to change the provideEntityDataWithoutEffects() to a better name.

I propose two options

1. Rename to provideBaseEntityData() and keep provideEntityData()

2. Use the pattern similar to the Angular Router

provideEntityData(config, [withEffects()])

Option 2 would be the default

[markostanimirovic]

Changes look good overall. We have an opportunity to change the provideEntityDataWithoutEffects() to a better name.

I propose two options

1. Rename to provideBaseEntityData() and keep provideEntityData()
2. Use the pattern similar to the Angular Router

provideEntityData(config, [withEffects()])

Option 2 would be the default

Sounds good to me 👍 I'm also not a big fan of ...withoutEffects name 😅

[brandonroberts]

LGTM.

We can change the signature in a follow-up PR

[santoshyadavdev]

I can make changes tonight, if you want to wait 😃

[brandonroberts]

Thanks Santosh! I think it's ok to go ahead and land this one. @markostanimirovic is going to look at the follow-up PR