Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: few tweaks to the migration guide #3649

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3615

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Added titles
Added some extra info
Reworded a few things

@netlify
Copy link

netlify bot commented Nov 5, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit fd74f51
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6367a99253f7e4000966bfc0
😎 Deploy Preview https://deploy-preview-3649--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


BEFORE:
#### Title
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced in #3648

@@ -41,7 +44,7 @@ mySelector.projector() // <- type is projector(...args: any[]): number

AFTER:

The projector is strict by default, but can be bypassed with an `any` generic parameter.
The projector is strict by default, but can be bypassed with an `any` type assertion to specify a less specific type.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the description because we didn't implement the any type generic

Co-authored-by: Brandon <robertsbt@gmail.com>
@markostanimirovic markostanimirovic merged commit 80b33a2 into master Nov 6, 2022
@markostanimirovic markostanimirovic deleted the docs/v15-migration branch November 6, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add migration guide for version 15 release
3 participants