Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(store): add example of createFeature extraSelectors #3787

Merged

Conversation

Armenvardanyan95
Copy link
Contributor

@Armenvardanyan95 Armenvardanyan95 commented Feb 24, 2023

closes #3775

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Documentation and examples have been added to the "Feature Creator" section of the "Advanced" documentation

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Closes #3775

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 71aed83
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6412fbad90c55d00085c58f6
😎 Deploy Preview https://deploy-preview-3787--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Armen!

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just one minor suggestion, so that the code formatting is consistent on this page:

projects/ngrx.io/content/guide/store/feature-creators.md Outdated Show resolved Hide resolved
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
@Armenvardanyan95
Copy link
Contributor Author

Thanks, @markostanimirovic, I added the suggestion

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Feel free to open a PR/issue for the entity+createFeature recipe.

@timdeschryver timdeschryver merged commit bbd44e6 into ngrx:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add docs for extraSelectors
3 participants