-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(store): add example of createFeature extraSelectors #3787
docs(store): add example of createFeature extraSelectors #3787
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Armen!
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
…/Armenvardanyan95/platform into docs/add-extra-selectors-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just one minor suggestion, so that the code formatting is consistent on this page:
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
Thanks, @markostanimirovic, I added the suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Feel free to open a PR/issue for the entity+createFeature recipe.
closes #3775
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Documentation and examples have been added to the "Feature Creator" section of the "Advanced" documentation
Closes #3775
Does this PR introduce a breaking change?