Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): untrack subscription in ngrxPush pipe #3918

Merged
merged 2 commits into from
May 31, 2023

Conversation

eneajaho
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

NgrxPush pipe has the same issue as async pipe: angular/angular#50382
Can be fixed same as: angular/angular#50522

Also added the same test that fails without the fix.

Repro: https://stackblitz.com/edit/stackblitz-starters-tapet4?file=src%2Fmain.ts

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6fe768c
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64773f50f088d80008b4485b
😎 Deploy Preview https://deploy-preview-3918--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brandonroberts brandonroberts merged commit a1688e4 into ngrx:main May 31, 2023
@brandonroberts
Copy link
Member

🔥

@matiasfs12
Copy link

Thanks! @eneajaho

va-stefanek pushed a commit to va-stefanek/platform that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants