Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add signals rules #4380

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4379

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Commit c2e17d3 further simplifies the eslint configuration.
I think this makes more sense to separate the rules by package, because the differences are too small to split things further up.

Other information

Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit f0ee4d9
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/66641ae42bd086000955f002

@timdeschryver timdeschryver force-pushed the eslint/add-signals-rules branch from c2e17d3 to f0ee4d9 Compare June 8, 2024 08:48
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brandonroberts brandonroberts merged commit c002466 into main Jun 10, 2024
5 checks passed
@brandonroberts brandonroberts deleted the eslint/add-signals-rules branch June 10, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eslint rule for signalState and withState
3 participants