Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select overload type annotations #944

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Fix select overload type annotations #944

merged 1 commit into from
Mar 30, 2018

Conversation

disquisition
Copy link
Contributor

Fixes #940.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.408% when pulling f330415 on disquisition:fix-select-overload-types into 71804ee on ngrx:next.

@MikeRyanDev MikeRyanDev merged commit bdc3056 into ngrx:next Mar 30, 2018
@disquisition disquisition deleted the fix-select-overload-types branch March 30, 2018 20:28
@brandonroberts brandonroberts mentioned this pull request Mar 31, 2018
Closed
@disquisition
Copy link
Contributor Author

There may have been a problem with this merge, I don't see the changes reflected in either next or master.

@brandonroberts
Copy link
Member

Something must have gotten lost in the transition to the 6.0.0 beta. Will you open a new PR against master?

@disquisition disquisition mentioned this pull request Apr 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disquisition @coveralls @brandonroberts @MikeRyanDev