Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add preliminary support for CJK languages #34

Closed
wants to merge 1 commit into from

Conversation

f0rb1d
Copy link

@f0rb1d f0rb1d commented Mar 10, 2021

This commit adds preliminary support for CJK languages.

To be specific, the original library would always output '1 minute' of reading for CJK languages. This commit fixes the issue, and more tests are on the way.

This commit adds preliminary support for CJK languages.

To be specific, the original library would always output '1 minute' of reading for CJK languages. This commit fixes the issue, and more tests are on the way.
@Josh-Cena
Copy link
Collaborator

By my understanding, a lot of characters between U+2E80 (0d11905) and U+4A37 (0d18999) are CJK as well, and the characters between U+A0000 (0d40960) and U+ABE0 (0d44000) do not look very CJK. Any rationale behind using the particular interval U+4A38 ~ U+ABE0?

You may consult the complete Unicode block on the Wikipedia page, if it helps.

The current version already works well for a typical CJK paragraph. I was just about to do the same thing before I saw your PR :P

@Josh-Cena
Copy link
Collaborator

@f0rb1d Are you going to continue working on this? I'm looking forward to this feature 👀

@Josh-Cena Josh-Cena mentioned this pull request May 21, 2021
@f0rb1d
Copy link
Author

f0rb1d commented Jun 2, 2021

@Josh-Cena Sorry I've been offline for a while, and I kinda forgot this stuff. It looks like you've done a much greater job than I did, so I would close this PR and help you finish yours. Let's discuss under #35.

@f0rb1d f0rb1d closed this Jun 2, 2021
@f0rb1d f0rb1d deleted the patch-1 branch June 2, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants