Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of @ngx-translate/core also installs “semantic-release” (since version 12.1.0) #1171

Closed
voorproever opened this issue Feb 13, 2020 · 9 comments · Fixed by lingounet/testage#10

Comments

@voorproever
Copy link

voorproever commented Feb 13, 2020

Current behavior

The @ngx-translate/core package seems to depend on semantic-release since v12.1.0:

Expected behavior

No installation of semantic-release since it’s a devDependency.

Minimal reproduction of the problem with instructions

npm install @ngx-translate/core
less package-lock.json
@ocombe ocombe closed this as completed in b61b731 Feb 13, 2020
@ocombe
Copy link
Member

ocombe commented Feb 13, 2020

Thanks, good catch! It'll be fixed in the next version (I won't release a new version just for that)

@viceice
Copy link

viceice commented Feb 14, 2020

Shouldn't it be a dependency on the root package.json?

@viceice
Copy link

viceice commented Feb 14, 2020

Or install without adding to package.json at all?

btw: latest semantic-release is v17.0.3 and you are using v8.2.3

@ocombe
Copy link
Member

ocombe commented Feb 14, 2020 via email

@nicolashenry
Copy link

@ocombe Is it released? I still have it installed with @ngx-translate/core 12.1.1 :
image

@demisx
Copy link

demisx commented Feb 27, 2020

Same issue here. The latest version still installs semantic-release@8.2.3 and generates warnings in Angular 9 when the latter tries to compile all npm dependencies as esm2015. Please remove it from the dependencies, since it's not a requirement to run your app code.

https://www.npmjs.com/package/@ngx-translate/core/v/12.1.1?activeTab=dependencies

@ocombe
Copy link
Member

ocombe commented Feb 27, 2020

Can you try 12.1.2 please? Hopefully it should be fixed for good now (based on https://www.npmjs.com/package/@ngx-translate/core/v/12.1.2?activeTab=dependencies)

@nicolashenry
Copy link

Seems fixed, thanks!

@demisx
Copy link

demisx commented Feb 29, 2020

Yep, it's fixed. Thank you @ocombe 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants