-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Router] RouterCancel #542
Comments
Have the same issue. You can reproduce it by adding a canDeactivate Guard that return false on a givin route. I think the RouterCancel and RouterError should be handled differently in the State.
|
I also wonder if the RouteNavigation should be cancelled when a route guard prevents the navigation so that an ActionHandler would be able to handle the following:
RouterPlugin actions should cover the actions lifecycle or have the following actions:
|
Just ran into the same issue. This bug makes this plugin pretty much incompatible with route guards :( |
similar issue : #658 |
@deebloo also we have types issue:
https://github.com/xmlking/ngx-starter-kit/blob/develop/libs/core/src/lib/state/eventbus.ts#L74 this looks like a solution for type issues: wonder if anyone working on fixing this plugin. if any help needed I can contribute. |
@xmlking Whould you like to try submit a PR for this issue? |
Im not sure it's linked to this bug but:
I'm using v3.4.3. Edit: The bug is only in dev, it disappears in prod. |
@gfeller @thomas-ama could you test with the latest NGXS v3.5.0 and confirm if the issue still exists? |
I was just testing it and in dev it still happens. |
Sadly, I'm seeing this on dev and prod |
@qstiegler @troydietz (and any others) would it be possible to test if this is fixed with the latest |
Hi, I was working with @troydietz when he reported our issue. I tested with the latest @dev version of NGXS router plugin and could not reproduce. Thanks for the quick fix! |
@markwhitfeld Fix looks good for me. Thanks for your effort! |
Thank you for your time guys, I appreciate that. Now I'm sure we can deliver that fix. |
Fixed in the v3.5.1 release! Closing this issue. |
Versions
Observed behavior
After "[Router] RouterCancel" the router state is not in sync with the current route:
The RouterCancel does not revert the state:
Desired behavior
The "router"-state should be in sync with the current route.
The text was updated successfully, but these errors were encountered: