GetCurrentTransaction().IsActive?

[nfplee]

I've just upgrade NHibernate it is telling me session.Transaction is now obselete and to use GetCurrentTransaction instead. However I noticed in the ThreadLocalSessionContext.cs file that it says:

var transaction = orphan.GetCurrentTransaction();
if (transaction?.IsActive == true)

Is the IsActive check needed? Couldn't it just check that transaction is not null since I thought GetCurrentTransaction would return null if it's not active.

[bahusoid]

Is the IsActive check needed? I thought GetCurrentTransaction would return null if it's not active.

Yeah it's not needed. You can skip this check in your code. I don't remember why it's been left but for some legacy obscure custom transaction handling cases

[hazzik]

Probably we don't need it either.

[nfplee]

Thanks both of you.