-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add left join support for Linq query provider #2328
Conversation
Please resolve conflicts |
Rebased and commented the Linq to Objects query. |
src/NHibernate/Linq/GroupJoin/NonAggregatingGroupJoinRewriter.cs
Outdated
Show resolved
Hide resolved
Rebased. |
…oin extension method
@maca88 I'm trying to understand why we need booth |
At first I tried to use nhibernate-core/src/NHibernate/Linq/Visitors/QuerySourceIdentifier.cs Lines 63 to 64 in 0132e4c
I was also thinking about tracking which JoinClause is an outer join in order to avoid having a wrapper, but the problem is that JoinClause can be cloned when rewriting the query model, which would probably ends up with a more complex solution.
|
@hazzik Do you still have some pending questions/plans with reviewing this PR? |
Oups.. Something is not right... LINQ tests are failing on master after merge |
There is some interference with #2324. |
Fixes: #864
This PR provides two additional ways to do a left join: