Rename ISQLFunctionExtended.FunctionName to Name #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maca88
commented
Apr 22, 2020
| @@ -10,7 +10,7 @@ internal interface ISQLFunctionExtended : ISQLFunction | |||
| /// <summary> | |||
| /// The function name or <see langword="null"/> when multiple functions/operators/statements are used. | |||
| /// </summary> | |||
| string FunctionName { get; } | |||
| string Name { get; } | |||
There was a problem hiding this comment.
Not a breaking change as ISQLFunctionExtended is not yet released.
fredericDelaporte
approved these changes
May 10, 2020
fredericDelaporte
added
t: Fix
and removed
c: DataProviders / Dialects
p: Lowest
t: Improvement
labels
|
I have qualified it as a fix of #2061 since I do not see much value in surfacing this in the release notes. |
hazzik
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @hazzik in comment, to avoid the need of obsoleting
NoArgSQLFunction.Name.