NH-3918 - Nominate equality expressions in SELECT clauses #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts in them * Allow for entity equality to be correctly translated to HQL * Prevents unneeded joins and caching of entities in the query plan
|
Rebased on master |
|
Can this be included in 4.1.0? |
|
I prefer to proceed with 4.1 as is rather than risk further delays by going into reviewing something. There is always going to be "one more PR". Better we try to get back to more frequent releases. |
oskarb
reviewed
Nov 26, 2016
| var bob = session.Query<Owner>().Single(o => o.Name == "Bob"); | ||
|
|
||
| var queryWithWhere = session.Query<Entity>() | ||
| .Where(WhereExpression(bob)) |
There was a problem hiding this comment.
Note for future - this indenting looks wrong depending on tab-size, because tab has been used also for alignment within a statement. Tabs are for indenting, space for alignment.
There was a problem hiding this comment.
Noted. NH differs from my usual development that uses spaces for everything, so I'm used to just pressing tab to align things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with constants in them