fix: preserve newlines in code block when pasting (fix #693)

nhn · Nov 26, 2019 · a4597c1 · a4597c1
1 parent 4be7ee2
commit a4597c1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/js/wwClipboardManager.js b/src/js/wwClipboardManager.js
@@ -120,7 +120,8 @@ class WwClipboardManager {
     const textNodes = domUtils.getAllTextNode(node);
 
     textNodes.forEach((textNode) => {
-      if (/\n/.test(textNode.nodeValue)) {
+      if (domUtils.getNodeName(textNode.parentNode) === 'SPAN' &&
+        /\n/.test(textNode.nodeValue)) {
         textNode.parentNode.innerHTML = textNode.nodeValue.replace(/\n/g, '<br>');
       }
     });

diff --git a/test/unit/wwClipboardManager.spec.js b/test/unit/wwClipboardManager.spec.js
@@ -108,5 +108,23 @@ describe('WwClipboardManager', () => {
       expect(range.startContainer.nodeType === Node.TEXT_NODE).toBe(true);
       expect(range.endContainer.nodeType === Node.TEXT_NODE).toBe(true);
     });
+
+    describe('_replaceNewLineToBr', () => {
+      it('replace newlines to br in plain text only', () => {
+        const node = $('<span>foo\nbar</span>')[0];
+
+        cbm._replaceNewLineToBr(node);
+
+        expect(node.innerHTML).toBe('foo<br>bar');
+      });
+
+      it('preserve newlines in code block', () => {
+        const node = $('<pre>foo\nbar</pre>')[0];
+
+        cbm._replaceNewLineToBr(node);
+
+        expect(node.innerHTML).toBe('foo\nbar');
+      });
+    });
   });
 });