chore: add test case(converting the html block which has "=" attr value)

nhn · Jul 6, 2021 · d5d6c56 · d5d6c56
1 parent 5aef309
commit d5d6c56
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/apps/editor/src/__test__/unit/convertor.spec.ts b/apps/editor/src/__test__/unit/convertor.spec.ts
@@ -828,6 +828,13 @@ describe('Convertor', () => {
       assertConverting(markdown, markdown);
     });
 
+    it('should convert html block element which has "=" character as the attribute value', () => {
+      const markdown =
+        '<iframe width="420" height="315" src="//player.bilibili.com/player.html?aid=588782532&bvid=BV1hB4y1K7ro&cid=360826679&page=1"></iframe>';
+
+      assertConverting(markdown, markdown);
+    });
+
     it('should convert html inline node', () => {
       const markdown = '<big class="my-big">content</big>';
 

diff --git a/apps/editor/src/wysiwyg/nodes/html.ts b/apps/editor/src/wysiwyg/nodes/html.ts
@@ -24,10 +24,10 @@ export function getHTMLAttrsByHTMLString(html: string) {
 
   return attrs
     ? attrs.reduce<Record<string, string | null>>((acc, attr) => {
-        const [name, ...value] = attr.trim().split('=');
+        const [name, ...values] = attr.trim().split('=');
 
-        if (value.length > 0) {
-          acc[name] = value.join('=').replace(/'|"/g, '').trim();
+        if (values.length) {
+          acc[name] = values.join('=').replace(/'|"/g, '').trim();
         }
 
         return acc;