Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shift-tab shortcut is not worked with the ordered list in markdown editor(fix #1014) #1015

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix: shift-tab shortcut is not worked with the ordered list in markdown editor(fix #1014) #1015

merged 1 commit into from
Jun 8, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jun 2, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

related issue(#1014)

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

seonim-ryu
seonim-ryu approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[6/3] 👍

@js87zz js87zz merged commit d9b9412 into master Jun 8, 2020
@js87zz js87zz deleted the fix/shift-tab-key-map branch June 8, 2020 02:10
@seonim-ryu seonim-ryu added this to the 2.2.0 milestone Jun 11, 2020
js87zz pushed a commit that referenced this pull request Jun 17, 2021
@seonim-ryu
fix: wrong popup position (fix #1014, #1015)
1403676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seonim-ryu seonim-ryu seonim-ryu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@js87zz @seonim-ryu