Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: heading removed when changing to paragraph in wysiwyg (fix #878) #1040

Merged
merged 1 commit into from
Jun 11, 2020
Merged

fix: heading removed when changing to paragraph in wysiwyg (fix #878) #1040

merged 1 commit into from
Jun 11, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Jun 10, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

TO-BE
test

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu requested review from js87zz and shiren June 10, 2020 03:29
shiren
shiren approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@shiren shiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

js87zz
js87zz approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이견없습니다. 고생하셨습니다 👍

@seonim-ryu seonim-ryu merged commit 7c00b60 into master Jun 11, 2020
@seonim-ryu seonim-ryu added this to the 2.2.0 milestone Jun 11, 2020
@seonim-ryu seonim-ryu deleted the fix/remove-heading-wysiwyg branch June 16, 2020 10:46
js87zz pushed a commit that referenced this pull request Jun 17, 2021
@seonim-ryu
feat: use squire official (fix #1018)
3ebcdd6 
#1018 #1043
#1030 #1031 #1037 #1038 #1039 #1040 #1041 #1042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

@shiren shiren shiren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seonim-ryu @shiren @js87zz