Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken cell redering with span tag using table-merged-cell plugin (fix #1059) #1060

Merged
merged 4 commits into from
Jul 20, 2020
Merged

fix: broken cell redering with span tag using table-merged-cell plugin (fix #1059) #1060

merged 4 commits into from
Jul 20, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Jun 24, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu changed the title fix: broken cell redering with span tag using table-merged-cell plugi… fix: broken cell redering with span tag using table-merged-cell plugin (fix #1059) Jun 24, 2020
@seonim-ryu seonim-ryu requested review from js87zz and shiren June 24, 2020 11:46
js87zz
js87zz reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergedTableParser.spec.js에도 이스케이프 관련된 테스트 케이스가 추가되면 좋을 것 같습니다. 고생하셨습니다!

shiren
shiren reviewed Jun 26, 2020
View reviewed changes
Copy link
Member

@shiren shiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요

plugins/table-merged-cell/test/tableRenderer.spec.js Outdated Show resolved Hide resolved
@seonim-ryu seonim-ryu force-pushed the fix/broken-table-cell branch from bb88796 to c250fe0 Compare July 19, 2020 11:11
@seonim-ryu seonim-ryu merged commit ac023d7 into master Jul 20, 2020
@seonim-ryu seonim-ryu deleted the fix/broken-table-cell branch July 21, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiren shiren shiren left review comments

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seonim-ryu @shiren @js87zz