Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: script error occurs in the wysiwyg table (fix #1110) #1111

Merged
merged 2 commits into from
Jul 20, 2020
Merged

fix: script error occurs in the wysiwyg table (fix #1110) #1111

merged 2 commits into from
Jul 20, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Jul 20, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu changed the title fix: script error occurs in the wysiwyg table fix: script error occurs in the wysiwyg table (fix #1110) Jul 20, 2020
@seonim-ryu seonim-ryu requested review from js87zz, lja1018 and shiren July 20, 2020 00:45
lja1018
lja1018 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[07/20] 리뷰완료.
고생하셨습니다~

@seonim-ryu seonim-ryu merged commit 6be680c into master Jul 20, 2020
@seonim-ryu seonim-ryu deleted the fix/table-script-error branch July 21, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lja1018 lja1018 lja1018 approved these changes

@js87zz js87zz Awaiting requested review from js87zz

@shiren shiren Awaiting requested review from shiren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seonim-ryu @lja1018