-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add key action to table in markdown #1126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[07/28] 리뷰완료.
고생하셨습니다!
apps/editor/src/js/markdownEditor.js
Outdated
|
||
this.cm.setCursor({ line: line - 1, ch: ch - 1 }); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
키맵핑 부분은 command
로 별도 분리하는게 더 깔끔하지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
커맨드로 분리해서 적용한 커밋입니다ㅎㅎ
e54b659
to
c15692c
Compare
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
Use case 1: tab key
Pressing the
tab
key in the markdown table moves the cursor cell by cell.Before
tab
: The text is indented in the cell.shift + tab
: The text is outdented in the cell.After
tab
:tab
moves to the next cell.tab
moves to the first cell in the next row.tab
in the last cell of the table, he cursor is positioned outside the table (ending point).shift + tab
:shift + tab
moves to the previous cell.shift + tab
moves to the last cell in the previous row.shift + tab
in the first cell of the table, the cursor is positioned outside the table (starting point).Use case 2 : enter key
Pressing the
enter key
in the markdown table adds the syntax for the new row.Before
After
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨