Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n hr-HR #1162

Merged
merged 3 commits into from
Aug 25, 2020
Merged

feat: i18n hr-HR #1162

merged 3 commits into from
Aug 25, 2020

Conversation

hrvoj3e
Copy link
Contributor

@hrvoj3e hrvoj3e commented Aug 24, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • The commit message follows our guidelines
  • It does not introduce a breaking change or has a description of the breaking change

Description

Add Croatian language to I18n.

Croatian language
@hrvoj3e hrvoj3e mentioned this pull request Aug 24, 2020
@seonim-ryu seonim-ryu self-requested a review August 25, 2020 08:12
@seonim-ryu
Copy link
Member

@hrvoj3e Thanks. I reviewed it and could you add a few more?

  • Add language to README : Add language information added to the content of Features> Internationalization (i18n).
  • Add language to table-merged-cell plugin : It should also be added to the table-merged-cell. At the end of this file, you can add the language value to be added.

If you only deal with two things, I'll merge them.

Add language information added to the content of Features> Internationalization (i18n)
@hrvoj3e
Copy link
Contributor Author

hrvoj3e commented Aug 25, 2020

@seonim-ryu I have added the two requested changes. Is this OK?

Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrvoj3e Perfect! 👍 It is good to keep the commit message well and write it. Thanks for your contributing. I'll merge this PR. 😃

@seonim-ryu seonim-ryu added this to the 2.4.0 milestone Aug 25, 2020
@seonim-ryu seonim-ryu merged commit 855abe6 into nhn:master Aug 25, 2020
@hrvoj3e hrvoj3e deleted the patch-1 branch July 31, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants