Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken type of plugin option when using table-merged-cell plugin (fix #1160) #1164

Merged
merged 1 commit into from
Aug 26, 2020
Merged

fix: broken type of plugin option when using table-merged-cell plugin (fix #1160) #1164

merged 1 commit into from
Aug 26, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Aug 25, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu added this to the 2.4.0 milestone Aug 25, 2020
@seonim-ryu seonim-ryu added the Bug label Aug 25, 2020
js87zz
js87zz approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seonim-ryu seonim-ryu merged commit 60e747a into master Aug 26, 2020
@seonim-ryu seonim-ryu deleted the fix/broken-type-plugin-option branch August 26, 2020 11:29
@seonim-ryu seonim-ryu removed this from the 2.4.0 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seonim-ryu @js87zz