Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds npm script to fix README instructions (fix #904) #1190

Merged
merged 1 commit into from
Sep 16, 2020
Merged

chore: Adds npm script to fix README instructions (fix #904) #1190

merged 1 commit into from
Sep 16, 2020

Conversation

dvargas92495
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

I was working on #1188 when I ran into the README being out of date. Took this as an opportunity to update them with a script that does all the steps outlined here, which unblocked me during local development


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu self-requested a review September 16, 2020 01:25
Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed it and it's nice that the way you added will be improved to make it easier to develop. This PR will be merged. Thanks for the contribution. 👍

@seonim-ryu seonim-ryu merged commit ff74fc7 into nhn:master Sep 16, 2020
@dvargas92495 dvargas92495 deleted the Fix_README branch September 16, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants