Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved norwegian translations #1207

Merged
merged 3 commits into from
Sep 25, 2020
Merged

fix: Improved norwegian translations #1207

merged 3 commits into from
Sep 25, 2020

Conversation

fela98
Copy link
Contributor

@fela98 fela98 commented Sep 19, 2020

Improved norwegian translations.

Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fela98 I don't know much about Norwegian, but if the terms you edited are officially used in Norwegian, I'll approve this PR. And the table-merged-cell plugin also supports i18n files. Could you please review if Norwegian is being used well here?

https://github.com/nhn/tui.editor/blob/master/plugins/table-merged-cell/src/js/langs.js

If there is anything to be modified, I would appreciate it if you edit the file above and commit it together. When the verification is complete, I will merge this PR.

@fela98
Copy link
Contributor Author

fela98 commented Sep 23, 2020

Ok, I translated the file. I'm from Norway and I also double checked with equivalent Norwegian translations of Excel and Word.

Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fela98 I've checked all the extra work you've done. 👍 I'll merge this PR. Thanks for your contributing!

@seonim-ryu seonim-ryu added the Enhancement Enhance performance or improve usability of original features. label Sep 25, 2020
@seonim-ryu seonim-ryu merged commit b129c66 into nhn:master Sep 25, 2020
@seonim-ryu seonim-ryu added this to the editor@2.5.0 milestone Oct 21, 2020
@seonim-ryu seonim-ryu removed the Enhancement Enhance performance or improve usability of original features. label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants