Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type definitions in customHTMLRenderer prop #1460

Merged
merged 1 commit into from
Apr 14, 2021
Merged

fix: type definitions in customHTMLRenderer prop #1460

merged 1 commit into from
Apr 14, 2021

Conversation

hackey9
Copy link
Contributor

@hackey9 hackey9 commented Mar 31, 2021 •
edited by js87zz
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • changed wrong type definition for customHTMLRenderer

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz changed the title Fix type definitions in customHTMLRenderer prop fix: type definitions in customHTMLRenderer prop Apr 14, 2021
@js87zz
Copy link
Contributor

js87zz commented Apr 14, 2021

@hackey9
Thank you for contributing!

@js87zz js87zz merged commit c7450cf into nhn:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackey9 @js87zz