Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot convert details, summary block using useDefaultHTMLSanitizer: false option #1472

Merged
merged 3 commits into from
Apr 16, 2021
Merged

fix: cannot convert details, summary block using useDefaultHTMLSanitizer: false option #1472

merged 3 commits into from
Apr 16, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Apr 16, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • fixed that cannot convert details, summary block using useDefaultHTMLSanitizer: false option.

as-is
2021-04-16 09-31-30 2021-04-16 09_31_42

to-be
2021-04-16 09-30-36 2021-04-16 09_30_48

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz requested review from dongsik-yoo, heenakwag, jung-han, jungeun-cho, lja1018 and shiren and removed request for jung-han April 16, 2021 00:33
jung-han
jung-han approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다!

jungeun-cho
jungeun-cho approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

lja1018
lja1018 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

shiren
shiren approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@shiren shiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

apps/editor/src/js/mdPreview.js Outdated Show resolved Hide resolved
libs/toastmark/src/__sample__/index.ts Outdated Show resolved Hide resolved
@js87zz js87zz merged commit 11b40c3 into master Apr 16, 2021
@js87zz js87zz deleted the fix/summary branch April 16, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungeun-cho jungeun-cho jungeun-cho approved these changes

@jung-han jung-han jung-han approved these changes

@lja1018 lja1018 lja1018 approved these changes

@shiren shiren shiren approved these changes

@dongsik-yoo dongsik-yoo Awaiting requested review from dongsik-yoo

@heenakwag heenakwag Awaiting requested review from heenakwag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@js87zz @shiren @lja1018 @jung-han @jungeun-cho