Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use destroy instead of remove for vuejs #1583

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

thomas-netlor
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@caio-tenorio
Copy link

caio-tenorio commented Jun 17, 2021

Thanks for that, i'm currently having an issue because of this.

Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomas-netlor
I will release the bugfix within next week. Thank you!

@js87zz js87zz merged commit 999b9e2 into nhn:master Jun 18, 2021
@bobvandevijver
Copy link

@js87zz Can I bother you to create a release? Looks like this bug is the only one blocking us to upgrade to v3 :)

@js87zz
Copy link
Contributor

js87zz commented Jul 5, 2021

@thomas-netlor @caio-tenorio @bobvandevijver
The vue-wrapper has been published(v3.0.1). The Main editor bug will probably be fixed and released within this week.
Thanks!

@js87zz js87zz changed the title Use destroy instead of remove for vuejs fix: use destroy instead of remove for vuejs Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants