Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: html attrs parse #1630

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix: html attrs parse #1630

merged 1 commit into from
Jul 6, 2021

Conversation

z-950
Copy link
Contributor

@z-950 z-950 commented Jul 2, 2021

fix #1620

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Fixed html attrs parse.

js87zz
js87zz approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@js87zz js87zz merged commit 9e1af8d into nhn:master Jul 6, 2021
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@z-950
fix: html attrs parse (fix nhn#1620) (nhn#1630)
aa77db2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The url in html attr that with query parses incorrently
2 participants
@z-950 @js87zz