Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin bundle config and dependencies env #1649

Merged
merged 3 commits into from
Jul 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,15 @@ Unsure where to begin contributing to TOAST UI? You can start by looking through
### Development WorkFlow
- Set up your development environment
- Make change from a right branch
- Be sure the code passes `npm run lint`, `npm run test`
- Be sure the code passes `npm run lint:all`, `npm run test:types:all`, `npm run test:all`
- Make a pull request

### Development environment
- Prepare your machine node and it's packages installed.
- Checkout our repository
- Install dependencies by `npm install && bower install`
- Start webpack-dev-server by `npm run serve`
- Install dependencies by `npm install`
- Build toastmark by `npm run build toastmark`
- Start snowpack-dev-server by `npm run serve`

### Make changes
#### Checkout a branch
Expand All @@ -61,7 +62,7 @@ Unsure where to begin contributing to TOAST UI? You can start by looking through
Run `npm run eslint` and make sure all the tests pass.

#### Test
Run `npm run test` and verify all the tests pass.
Run `npm run test:all` and verify all the tests pass.
If you are adding new commands or features, they must include tests.
If you are changing functionality, update the tests if you need to.

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ Fork `main` branch into your personal repository. Clone it to local computer. In
```sh
$ git clone https://github.com/{your-personal-repo}/tui.editor.git
$ npm install
$ npm run build toastmark
$ npm run test editor
```

Expand Down
4 changes: 1 addition & 3 deletions apps/editor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@
},
"devDependencies": {
"@toast-ui/release-notes": "^2.0.1",
"cross-env": "^6.0.3",
"rollup": "2.52.0",
"@rollup/plugin-typescript": "8.2.1"
"cross-env": "^6.0.3"
},
"dependencies": {
"prosemirror-commands": "^1.1.9",
Expand Down
Loading