Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: converting bullet list item with the ordered number contents(v2) #1669

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jul 12, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

sample data

const editor = newEditor({
  // ...
  initialValue: '* 1. ordered num\n    *  child1\n    * child2'
});

as-is
스크린샷 2021-07-12 오전 11 47 56

to-be
스크린샷 2021-07-12 오전 11 47 22


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz changed the title fix: converting bullet list item with the ordered number contents fix: converting bullet list item with the ordered number contents(v2) Jul 12, 2021
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

Copy link
Contributor

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz merged commit 7855b90 into 2.x Jul 13, 2021
@js87zz js87zz deleted the fix/bullet-list-converting branch July 13, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants