Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add z-index css to wysiwyg editor contents for IE11 #1745

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Aug 9, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • added z-index css to wysiwyg editor contents for IE11. The wysiwyg contents is not displayed in IE.
    2021-08-09 12-47-09 2021-08-09 12_47_41

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 100이라는 수치는 애플리케이션 스타일링 전반적으로 봤을 때 일정한 규칙에 의해 정해진건가요? 아니면 적당히 큰 값을 주기 위해 임의로 들어간 값인가요?

@js87zz
Copy link
Contributor Author

js87zz commented Aug 9, 2021

리뷰 완료합니다. 100이라는 수치는 애플리케이션 스타일링 전반적으로 봤을 때 일정한 규칙에 의해 정해진건가요? 아니면 적당히 큰 값을 주기 위해 임의로 들어간 값인가요?

현재 context에 따라 -1, 0, 10, 100, 999, 9999 이렇게만 사용하고 있습니다~ 이 참에 10단위로 통일하던가 해야겠네요.

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.
저도 도형전임님과 같은 질문을 하려헀으나 답변을 보고 생략합니다!

Copy link
Contributor

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. z-index는 지정값이 있으면 따로 주석으로 상수화 해두는 것도 괜찮을 것 같기도 합니다.

@js87zz js87zz merged commit 89fd3c1 into master Aug 10, 2021
@js87zz js87zz deleted the fix/z-index branch August 10, 2021 02:30
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
* fix: add z-index: 100 to toastui-editor-contents for IE11

* chore: apply code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants