fix: the editor cannot apply empty string attributes to wysiwyg node #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Aug 30, 2021
|
|
||
| const result = oneLineTrim` | ||
| <iframe width="" height="" src="" class="html-block"></iframe> | ||
| <p>test</p> |
There was a problem hiding this comment.
속성의 빈값을 확인 하는 것 외에 다른 컨텐츠가 들어가야 할 필요가 있었어요?
There was a problem hiding this comment.
딱히 의미가 없네요. 해당 텍스트는 제거하겠습니다~
| @@ -864,6 +864,25 @@ describe('editor', () => { | |||
|
|
|||
| expect(wwEditor.innerHTML).toContain(result); | |||
| }); | |||
|
|
|||
| it('should keep the html block attributes with an empty string after changing the mode', () => { | |||
js87zz
force-pushed
the
fix/empty-string-attributes
branch
from
ebc207a to
ae87ad1
Compare
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
…hn#1781) * fix: add controls attribute for video * fix: set attritutes properly with empty string * chore: add test case(empty string attributes) * fix: remove attribute when value is null or undefined * chore: apply code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨