fix: user cannot insert the $$ text due to custom inline syntax
#1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhrinae
approved these changes
Sep 6, 2021
| try { | ||
| return customConvertor!(node, context); | ||
| } catch (e) { | ||
| console.warn(e); |
There was a problem hiding this comment.
라이브러리이니만큼 약간은 메세지를 데코레이션 해줘야 하지 않으려나요?
"[tui.editor] 무슨 컨버터 써서 문법 변환하다 오류 났다" 같은 느낌으로요.
There was a problem hiding this comment.
아래처럼 변경했습니다~
[@toast-ui/editor] - The error occurred when ${info} inline node was parsed in markdown renderer: ${e}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
as-is
to-be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨