Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace childElement when component is updated (fix #2028) #2029

Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix: replace childElement when component is updated (fix #2028) #2029

merged 1 commit into from
Dec 2, 2021

Conversation

PaulSchult
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

See #2028

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@PaulSchult
Copy link
Contributor Author

would probably change replaceChild with replaceWith because its faster and less error prone. lmk what you think and I will replace it

js87zz
js87zz approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for the late review!
replaceWith is not supported by IE11, so it would be better to keep it as replaceChild.

@js87zz js87zz merged commit 1f2abfc into nhn:master Dec 2, 2021
@js87zz js87zz mentioned this pull request Dec 27, 2021
Closed
@js87zz js87zz mentioned this pull request Feb 9, 2022
Open
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@PaulSchult
fix: replace childElement when component is updated (fix nhn#2028) (n…
2421a76 
…hn#2029)

Co-authored-by: pschult <paul.schult@wspsoft.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulSchult @js87zz