-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: frozen browser when cutting table contents(2.x
)
#2055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료합니다.
핵심은 squire
쪽에서 레인지 가져올 때 isInTable
체크를 추가로 해주어야 하는 것 처럼 보이네요. 이런 답 안나오는 것 같은 상황에서 디버깅을 어떻게 하셨을지 ㄷㄷ
td.innerHTML = brString; | ||
} | ||
|
||
td.innerHTML = tdContent.length ? tdContent : brString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단순 질문인데요, 여기서 textContent
를 쓸 때랑 innerHTML
를 쓸 때 기존 대비 유의미한 차이가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
textContent
로 넣게 되면 디스크립션에 있는 리스트 예제 같은 경우도 dsdsdaaaaaaaa
처럼 요소의 텍스트만 붙여넣기가 되어서 데이터를 넣고 가져와 설정하는 부분을 모두 innerHTML
로 변경하였습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 리스트 등등도 있겠네요. 이해했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료합니다.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
2.x
legacy versionas-is(
ctrl + x
orcommand + x
)to-be(
ctrl + x
orcommand + x
)Thank you for your contribution to TOAST UI product. 🎉 😘 ✨