Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frozen browser when cutting table contents(2.x) #2055

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Nov 29, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • frozen browser when cutting table contents in 2.x legacy version

as-is(ctrl + x or command + x)
2021-11-29 09-25-15 2021-11-29 09_25_25

to-be(ctrl + x or command + x)
2021-11-29 09-23-05 2021-11-29 09_23_18


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.
핵심은 squire 쪽에서 레인지 가져올 때 isInTable 체크를 추가로 해주어야 하는 것 처럼 보이네요. 이런 답 안나오는 것 같은 상황에서 디버깅을 어떻게 하셨을지 ㄷㄷ

td.innerHTML = brString;
}

td.innerHTML = tdContent.length ? tdContent : brString;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단순 질문인데요, 여기서 textContent 를 쓸 때랑 innerHTML 를 쓸 때 기존 대비 유의미한 차이가 있나요?

Copy link
Contributor Author

@js87zz js87zz Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textContent로 넣게 되면 디스크립션에 있는 리스트 예제 같은 경우도 dsdsdaaaaaaaa 처럼 요소의 텍스트만 붙여넣기가 되어서 데이터를 넣고 가져와 설정하는 부분을 모두 innerHTML로 변경하였습니다~!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 리스트 등등도 있겠네요. 이해했습니다.

Copy link
Contributor

@jajugoguma jajugoguma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다!

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz merged commit e2ad633 into 2.x Nov 30, 2021
@js87zz js87zz deleted the fix/cut-table-contents branch November 30, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants