Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: heading state remains when changed to paragraph in WYSIWYG #2103

Merged
merged 2 commits into from
Dec 10, 2021
Merged

fix: heading state remains when changed to paragraph in WYSIWYG #2103

merged 2 commits into from
Dec 10, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Dec 9, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

adhrinae
adhrinae approved these changes Dec 10, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz force-pushed the fix/wysiwyg-heading-command branch from c713ca3 to f84069b Compare December 10, 2021 08:15
@js87zz js87zz merged commit 0b62896 into master Dec 10, 2021
@js87zz js87zz deleted the fix/wysiwyg-heading-command branch December 10, 2021 09:35
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: heading state remains when changed to paragraph in WYSIWYG (nhn#…
0a3c678 
…2103)

* fix: heading element is not changed to paragraph when executing heading command with level 0

* chore: add test case(wysiwyg heading command)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js87zz @adhrinae