fix: wrong escape with link, image url when converting #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhrinae
approved these changes
Dec 10, 2021
| @@ -12,6 +12,31 @@ const reEscapeHTML = /<([a-zA-Z_][a-zA-Z0-9\-._]*)(\s|[^\\/>])*\/?>|<(\/)([a-zA- | |||
| const reEscapeBackSlash = /\\[!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~\\]/g; | |||
| const reEscapePairedChars = /[*_~`]/g; | |||
|
|
|||
| const XMLSPECIAL = '[&<>"]'; | |||
| const reXmlSpecial = new RegExp(XMLSPECIAL, 'g'); | |||
There was a problem hiding this comment.
이 정규표현식은 리터럴로 표현이 안되어서 RegExp 객체로 만드신건가요?
There was a problem hiding this comment.
저 문자열들을 따로 사용해서 정규식을 만드는 경우가 있을 수 있어서 이전에 마크다운 파서에서처럼 똑같이 분리해서 작성해두었습니다. 추후 따로 재사용성이 전혀 없다고 판단되면 그때 통합할게요~
js87zz
force-pushed
the
fix/link-escape-when-converting
branch
from
27afee8 to
aa13340
Compare
|
Hi. Why do you need to escape |
|
@ibedarev |
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
* fix: wrong escape with link, image url * chore: add test case(image, link url escape)
|
Why not using encodeURI for url encode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨