fix: cannot emit load event in react wrapper
#2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js87zz
force-pushed
the
fix/react-wrapper-event
branch
from
23d8811 to
fabcaae
Compare
adhrinae
approved these changes
Dec 21, 2021
| @@ -1,6 +1,5 @@ | |||
| import React from 'react'; | |||
| // @ts-ignore | |||
| import Viewer from '@toast-ui/editor/dist/toastui-editor-viewer'; | |||
| import Viewer, { EventMap } from '@toast-ui/editor/dist/toastui-editor-viewer'; | |||
There was a problem hiding this comment.
그냥 궁금한건데, Viewer 는 dist 폴더에서 가져와야 하는 이유가 있나요?
There was a problem hiding this comment.
어플리케이션의 기본 export에서는 에디터만 제공합니다~! 뷰어는 번들 용량 문제도 있어서 별도 dist로 제공하고 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨