Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken converting to markdown when the node has double quote string attribute value #2143

Merged
merged 1 commit into from
Dec 21, 2021
Merged

fix: broken converting to markdown when the node has double quote string attribute value #2143

merged 1 commit into from
Dec 21, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Dec 20, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

lja1018
lja1018 reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

lja1018
lja1018 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

adhrinae
adhrinae approved these changes Dec 21, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz force-pushed the fix/converting-double-quote branch from 808e36f to d0c551b Compare December 21, 2021 05:08
@js87zz js87zz merged commit 0130ebb into master Dec 21, 2021
@js87zz js87zz deleted the fix/converting-double-quote branch December 21, 2021 05:16
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: broken converting to markdown when attributes has double quote s…
3988673 
…tring (nhn#2143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lja1018 lja1018 lja1018 approved these changes

@adhrinae adhrinae adhrinae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@js87zz @adhrinae @lja1018