Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong popup widget pos when scrolling #2271

Merged
merged 2 commits into from
Feb 9, 2022
Merged

fix: wrong popup widget pos when scrolling #2271

merged 2 commits into from
Feb 9, 2022

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Feb 7, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Contributor

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz merged commit 5df26bc into master Feb 9, 2022
@js87zz js87zz deleted the fix/widget-pos branch February 9, 2022 01:25
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
* feat: add loadUI event

* fix: wrong popup widget position with scroll position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants