fix: wrong customInline converting
#2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js87zz
approved these changes
Feb 8, 2022
Comment on lines
376
to
380
| text += info; | ||
|
|
||
| if (firstChild) { | ||
| text += ' '; | ||
| } |
There was a problem hiding this comment.
아래처럼 작성하는 건 어떤가요?
text += (firstChild ? `${info} ` : info)
chore: revert initial value of demo
js87zz
force-pushed
the
fix/custom-inline-parse
branch
from
0a00e67 to
be63452
Compare
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
* wip: fix the wrong converting custom inline node * refactor: improved code readability * chore: add test cases for custom inline * chore: fix broken test case * chore: remove unnecessary comment chore: revert initial value of demo * chore: change if statement to conditional operator Co-authored-by: js87zz <js87zz.lee@nhn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
$$xxx$$error #2167)Thank you for your contribution to TOAST UI product. 🎉 😘 ✨