Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only enable indent, outdent toolbar item in the list #2294

Merged
merged 4 commits into from
Feb 10, 2022
Merged

fix: only enable indent, outdent toolbar item in the list #2294

merged 4 commits into from
Feb 10, 2022

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Feb 8, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz merged commit 30743f6 into master Feb 10, 2022
@js87zz js87zz deleted the fix/toolbar-state branch February 10, 2022 04:42
@js87zz js87zz changed the title feat: only enable indent, outdent toolbar item in the list fix: only enable indent, outdent toolbar item in the list Feb 10, 2022
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz @jajugoguma
feat: only enable indent, outdent toolbar item in the list (nhn#2294
cd227a4 
)

* wip: enhance toolbar state(only enable `indent`, `outdent` item in list item)

* feat: only enable indent, outdent toolbar item in the list

* chore: fix that toolbar buttons activate in preview mode

* chore: fix broken test case

Co-authored-by: jajugoguma <daeyeon.kim@nhn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js87zz @jajugoguma