Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: editor cannot find the element using document.querySelector() in case of multiple editor instance #2298

Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix: editor cannot find the element using document.querySelector() in case of multiple editor instance #2298

merged 1 commit into from
Feb 10, 2022

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Feb 10, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz force-pushed the fix/codeBlockView-querySelector branch from 240c7f6 to 5c111cb Compare February 10, 2022 02:24
@js87zz js87zz merged commit f04c7dd into master Feb 10, 2022
@js87zz js87zz deleted the fix/codeBlockView-querySelector branch February 10, 2022 02:44
@js87zz js87zz mentioned this pull request Feb 10, 2022
Closed
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: remove document.querySelector() for multiple instance in wysiwyg…
a6036b3 
… code block view (nhn#2298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@js87zz