Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand plugin interface #2451

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

jwlee1108
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Contributor

@jajugoguma jajugoguma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다!

Comment on lines +134 to +135
inputRules: typeof inputRules;
InputRule: typeof InputRule;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이름을 왜 이렇게 작성하셨을까 했는데 prosemirror에서 원래 이렇게 되어있군요...!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거땜에 또 한 3시간 날렸어요..i 대소문자가 다를 줄 누가 알았겠어요..ㅠ

@jwlee1108 jwlee1108 merged commit a3326d5 into master Apr 14, 2022
@jwlee1108 jwlee1108 deleted the feat/expand-plugin-interface branch April 14, 2022 02:11
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants