-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep empty line between lists #2598
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bbaec65
fix: keep empty line between lists
jajugoguma eb5c94f
fix: remove delimiter when add empty line between list items
jajugoguma d39270a
test: add test for convertor
jajugoguma 659d9a8
chore: apply code reviews
jajugoguma 0aa31fb
Merge branch 'master' into fix/keep-empty-line-between-lists
jajugoguma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λμμ΄
wrapBlock
μ΄λΌλ λ©μλμ μ μ¬ν΄ 보μ΄λ€μ.tui.editor/apps/editor/src/convertors/toMarkdown/toMdConvertorState.ts
Lines 116 to 124 in d39270a
μμ½κ² μΈλΆμμλ delimμ λ€λ£¨κΈ° μν΄ λ©μλλ₯Ό λ§λ κ² κΉμ§ μ’μλ°,
ToMdConvertorState
ν΄λμ€ λ΄λΆμμλsetDelim
λ©μλλ₯Ό μ°μ§ μκ³this.delim
μ ν λΉμ νλ λμμ΄ λ§κ΅¬ μΌμ΄λκ³ μμΌλ μ½λμ μΌκ΄μ±μ΄ μμ΄ λ³΄μ¬μ.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ΄μ©μ΄ λκ°λ‘ λλμ΄μΌνλλ° λ¦¬λ·°λ₯Ό μ½λ€κ° νλλ‘ λμ³μ‘λ보λ€μ.
wrapBlock
μΌλ‘ λμ²΄κ° μλλμ§get/setDelim
λ©μλκ° λ§λ€μ΄μ‘μΌλthis.delim
μ λ€λ£° λ ν΄λΉ ν΄λμ€μ λͺ¨λ μ°κ΄ λμμ΄ μμ λμ΄μΌ νμ§ μλλμ λκ°λ λ€λ₯Έ λ§₯λ½μ΄μμ΄μ.
λ¬΄νΌ λ¦¬λ·° λ°μλ μ½λμλ
wrapBlock
λ§get/setDelim
λ§ μ μ©νκ³ μλλ°,flushClose
,write
λ©μλλ κ°μ λ³κ²½μ΄ νμν΄μ.