Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong position of the tooltip on the toolbar item #918

Merged
merged 2 commits into from
Apr 22, 2020
Merged

fix: wrong position of the tooltip on the toolbar item #918

merged 2 commits into from
Apr 22, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Apr 22, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • fix the wrong calculated offset position of tooltip on toolbar item. The offset position should be calculated based on document.body because tooltip element is attached to body.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

dongwoo-kim
dongwoo-kim approved these changes Apr 22, 2020
View reviewed changes
Copy link

@dongwoo-kim dongwoo-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료! 수고하셨습니다.

@js87zz js87zz merged commit ba861a5 into master Apr 22, 2020
@js87zz js87zz deleted the fix/toolbar-tooltip-position branch April 22, 2020 07:24
@seonim-ryu seonim-ryu added the Bug label Apr 23, 2020
@seonim-ryu seonim-ryu added this to the 2.1.0 milestone Apr 23, 2020
js87zz pushed a commit that referenced this pull request Jun 17, 2021
@seonim-ryu
feat(option): add an option disabling shortcuts
2074afd 
#917 #918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwoo-kim dongwoo-kim dongwoo-kim approved these changes

@seonim-ryu seonim-ryu Awaiting requested review from seonim-ryu

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@js87zz @dongwoo-kim @seonim-ryu