fix: wrong ordered list regexp when extending list by pressing the enter key #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js87zz
changed the title
dongwoo-kim
reviewed
Apr 22, 2020
| @@ -6,7 +6,7 @@ | |||
| import CodeMirror from 'codemirror'; | |||
|
|
|||
| /*eslint-disable */ | |||
| var listRE = /^(\s*)(>[> ]*|[*+-] \[[x ]\]\s|[*+-]\s|(\d+)([.)]))(\s*)/, | |||
| var listRE = /^(\s*)(>[> ]*|[*+-] \[[x ]\]\s|[*+-]\s|(\d+)([.)]\s))(\s*)/, | |||
There was a problem hiding this comment.
마크다운 스펙상의 문제는 해결이 됐는데, 사실 보고된 이슈는 다른 문제입니다.
코드 블록 내에서도 똑같이 발생하는 게 더 문제라서..
현재 커서 위치 혹은 툴바 state를 확인해서 코드 블록 내부에서는 동작하지 않도록 막는 처리를 해 줘야 할 것 같습니다.
dongwoo-kim
reviewed
Apr 23, 2020
seonim-ryu
reviewed
Apr 23, 2020
js87zz
force-pushed
the
fix/continuelist-regexp
branch
from
55c285c to
ede3fbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
1. aThank you for your contribution to TOAST UI product. 🎉 😘 ✨