Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not working shortcut of codemirror in markdown editor #951

Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix: not working shortcut of codemirror in markdown editor #951

merged 1 commit into from
Apr 28, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Apr 28, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • When CodeMirror is created, the extraKey value is overwritten and the shortcut does not work in the markdown editor.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

dongwoo-kim
dongwoo-kim approved these changes Apr 28, 2020
View reviewed changes
Copy link

@dongwoo-kim dongwoo-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seonim-ryu seonim-ryu added the Bug label Apr 28, 2020
@seonim-ryu seonim-ryu added this to the 2.1.0 milestone Apr 28, 2020
@dongwoo-kim dongwoo-kim merged commit 11016ef into master Apr 28, 2020
@dongwoo-kim dongwoo-kim deleted the fix/codemirror-shortcut branch April 28, 2020 06:50
js87zz pushed a commit that referenced this pull request Jun 17, 2021
@seonim-ryu
feat(ww): add source param in addImageBlobHook
536a525 
#951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwoo-kim dongwoo-kim dongwoo-kim approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seonim-ryu @dongwoo-kim